Skip to content

Commit

Permalink
feat(holdings-record): Restrict updating without sourceId
Browse files Browse the repository at this point in the history
- Delete validation from service

Closes: MODINVSTOR-1161
  • Loading branch information
viacheslavpoliakov committed May 21, 2024
1 parent 307c63f commit 61e7604
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/main/java/org/folio/services/holding/HoldingsService.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.folio.services.holding;

import static io.vertx.core.Future.failedFuture;
import static io.vertx.core.Promise.promise;
import static org.apache.logging.log4j.LogManager.getLogger;
import static org.folio.rest.impl.HoldingsStorageApi.HOLDINGS_RECORD_TABLE;
Expand All @@ -14,7 +13,6 @@
import static org.folio.rest.persist.PgUtil.post;
import static org.folio.rest.persist.PgUtil.postSync;
import static org.folio.rest.persist.PgUtil.postgresClient;
import static org.folio.rest.tools.utils.ValidationHelper.createValidationErrorMessage;
import static org.folio.services.batch.BatchOperationContextFactory.buildBatchOperationContext;
import static org.folio.validator.HridValidators.refuseWhenHridChanged;

Expand All @@ -33,7 +31,6 @@
import org.apache.logging.log4j.Logger;
import org.folio.persist.HoldingsRepository;
import org.folio.persist.InstanceRepository;
import org.folio.rest.exceptions.ValidationException;
import org.folio.rest.jaxrs.model.HoldingsRecord;
import org.folio.rest.jaxrs.model.Item;
import org.folio.rest.persist.PostgresClient;
Expand Down Expand Up @@ -91,11 +88,6 @@ public Future<Response> deleteAllHoldings() {
}

public Future<Response> updateHoldingRecord(String holdingId, HoldingsRecord holdingsRecord) {
if (holdingsRecord.getSourceId() == null) {
return failedFuture(new ValidationException(createValidationErrorMessage("sourceId",
holdingsRecord.getSourceId(), "The sourceId field required: cannot be null or deleted")));
}

return holdingsRepository.getById(holdingId)
.compose(existingHoldingsRecord -> {
if (holdingsRecordFound(existingHoldingsRecord)) {
Expand Down

0 comments on commit 61e7604

Please sign in to comment.