MODINV-943 Fix checkstyle violations

folio-org · May 30, 2024 · ed01989 · ed01989
1 parent b3b2975
commit ed01989
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/src/test/java/org/folio/rest/api/HoldingsStorageTest.java b/src/test/java/org/folio/rest/api/HoldingsStorageTest.java
@@ -533,28 +533,27 @@ public void canRetrieveAllHoldings() {
     instancesClient.create(nod(secondInstanceId));
     instancesClient.create(uprooted(thirdInstanceId));
 
-    var firstHoldingId = holdingsClient.create(new HoldingRequestBuilder()
+    CompletableFuture<Response> getCompleted = new CompletableFuture<>();
+
+    final var firstHoldingId = holdingsClient.create(new HoldingRequestBuilder()
       .forInstance(firstInstanceId)
       .withPermanentLocation(MAIN_LIBRARY_LOCATION_ID)).getId();
 
-    var secondHoldingId = holdingsClient.create(new HoldingRequestBuilder()
+    final var secondHoldingId = holdingsClient.create(new HoldingRequestBuilder()
       .forInstance(secondInstanceId)
       .withPermanentLocation(ANNEX_LIBRARY_LOCATION_ID)).getId();
 
-    var thirdHoldingId = holdingsClient.create(new HoldingRequestBuilder()
+    final var thirdHoldingId = holdingsClient.create(new HoldingRequestBuilder()
       .forInstance(thirdInstanceId)
       .withPermanentLocation(MAIN_LIBRARY_LOCATION_ID)
       .withTags(new JsonObject().put("tagList", new JsonArray().add(TAG_VALUE)))).getId();
 
-    var getCompleted = new CompletableFuture<Response>();
-
     getClient().post(holdingsStorageUrl("/retrieve"), new JsonObject(), TENANT_ID,
       ResponseHandler.json(getCompleted));
 
     var response = getCompleted.get(TIMEOUT, TimeUnit.SECONDS);
     var responseBody = response.getJson();
-    var allHoldings = JsonArrayHelper.toList(
-      responseBody.getJsonArray("holdingsRecords"));
+    var allHoldings = JsonArrayHelper.toList(responseBody.getJsonArray("holdingsRecords"));
 
     assertThat(allHoldings.size(), is(3));
     assertThat(responseBody.getInteger("totalRecords"), is(3));

diff --git a/src/test/java/org/folio/rest/api/InstanceStorageTest.java b/src/test/java/org/folio/rest/api/InstanceStorageTest.java
@@ -667,11 +667,11 @@ public void canRetrieveAllInstances() throws InterruptedException, ExecutionExce
     var firstInstanceToCreate = smallAngryPlanet(firstInstanceId);
     var secondInstanceId = UUID.randomUUID();
     var secondInstanceToCreate = nod(secondInstanceId);
-    var query = "title=\"Nod\"";
 
     createInstance(firstInstanceToCreate);
     createInstance(secondInstanceToCreate);
 
+    var query = "title=\"Nod\"";
     var retrieveCompleted = new CompletableFuture<Response>();
     var retrieveByTitleCompleted = new CompletableFuture<Response>();
 
@@ -692,14 +692,14 @@ public void canRetrieveAllInstances() throws InterruptedException, ExecutionExce
 
     var firstInstance = allInstances.getJsonObject(0);
     var secondInstance = allInstances.getJsonObject(1);
-    var foundInstance = foundInstances.getJsonObject(0);
     // no "sortBy" used so the database can return them in any order.
     // swap if needed:
     if (firstInstanceId.toString().equals(secondInstance.getString("id"))) {
       var tmp = firstInstance;
       firstInstance = secondInstance;
       secondInstance = tmp;
     }
+    final var foundInstance = foundInstances.getJsonObject(0);
 
     assertThat(firstInstance.getString("id"), is(firstInstanceId.toString()));
     assertThat(firstInstance.getString("title"), is("Long Way to a Small Angry Planet"));