-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODINVSTOR-1161 SourceId is allowed to be deleted for Holdings record #1024
Conversation
- Add validator to restrict updating without sourceId Closes: MODINVSTOR-1161
- Change raised Exception Closes: MODINVSTOR-1161
- Add tests to cover updating Closes: MODINVSTOR-1161
- Update NEWS.md Closes: MODINVSTOR-1161
- Delete validation from service Closes: MODINVSTOR-1161
- Clean code Closes: MODINVSTOR-1161
- Fix Sonar issues Closes: MODINVSTOR-1161
- Fix next Sonar issues Closes: MODINVSTOR-1161
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's breaking change (you make one field required) please bump a major version of holdings-storage interface (in module descriptor) and all related interfaces that do POST/PUT/PATCH operations with holdings record.
After that PR couldn't be merge until all dependant modules upgrade to newest interface versions.
- Add breaking changes notes Closes: MODINVSTOR-1161
- Edit NEWS.md Closes: MODINVSTOR-1161
# Conflicts: # descriptors/ModuleDescriptor-template.json
- Fix new tests Closes: MODINVSTOR-1161
|
Purpose
Restrict to update holdings with null or deleted sourceId
Approach
Make sourceId as required field
Changes Checklist
Related Issues
MODINVSTOR-1161