Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODINVSTOR-1161 SourceId is allowed to be deleted for Holdings record #1024

Merged
merged 14 commits into from
Jun 18, 2024

Conversation

viacheslavpoliakov
Copy link
Contributor

@viacheslavpoliakov viacheslavpoliakov commented May 21, 2024

Purpose

Restrict to update holdings with null or deleted sourceId

Approach

Make sourceId as required field

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODINVSTOR-1161

- Add validator to restrict updating without sourceId

Closes: MODINVSTOR-1161
- Change raised Exception

Closes: MODINVSTOR-1161
- Add tests to cover updating

Closes: MODINVSTOR-1161
- Update NEWS.md

Closes: MODINVSTOR-1161
@viacheslavpoliakov viacheslavpoliakov marked this pull request as ready for review May 21, 2024 10:28
@viacheslavpoliakov viacheslavpoliakov requested a review from a team as a code owner May 21, 2024 10:28
Copy link
Contributor

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's breaking change (you make one field required) please bump a major version of holdings-storage interface (in module descriptor) and all related interfaces that do POST/PUT/PATCH operations with holdings record.

After that PR couldn't be merge until all dependant modules upgrade to newest interface versions.

- Add breaking changes notes

Closes: MODINVSTOR-1161
NEWS.md Outdated Show resolved Hide resolved
- Edit NEWS.md

Closes: MODINVSTOR-1161
# Conflicts:
#	descriptors/ModuleDescriptor-template.json
- Fix new tests

Closes: MODINVSTOR-1161
Copy link

@psmagin psmagin merged commit 00bf9d1 into master Jun 18, 2024
6 checks passed
@psmagin psmagin deleted the MODINVSTOR-1161 branch June 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants