Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODINVSTOR-1266 Append bounded items to invetory-view instances response #1107

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

illia-borysenko
Copy link
Contributor

@illia-borysenko illia-borysenko commented Oct 29, 2024

Purpose

https://folio-org.atlassian.net/browse/MODINVSTOR-1266

Append bounded items to reponse of GET /inventory-view/instances endpoint when withBoundedItems param is true

Approach

Do SQL modified query based on the parameter to retrieve data from "instance_holdings_item_view" DB View with appended bounded items by joining data from "bound_with_part" and "items" tables.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

@illia-borysenko illia-borysenko self-assigned this Oct 29, 2024
@illia-borysenko illia-borysenko requested a review from a team as a code owner October 29, 2024 14:59
@illia-borysenko illia-borysenko force-pushed the MODINVSTOR-1266 branch 2 times, most recently from 5627bca to 1b959ff Compare October 30, 2024 10:23
Copy link

@illia-borysenko illia-borysenko merged commit b90402a into master Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants