Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODINVSTOR-1154] - Add new field "Display summary" for the item schema #956

Merged
merged 9 commits into from
Jan 25, 2024
Merged

[MODINVSTOR-1154] - Add new field "Display summary" for the item schema #956

merged 9 commits into from
Jan 25, 2024

Conversation

azizbekxm
Copy link
Contributor

@azizbekxm azizbekxm commented Jan 23, 2024 •
edited
Loading

Purpose

https://issues.folio.org/browse/MODINVSTOR-1154

Approach

added new field to item schema

Changes Checklist

  • API Changes: List any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Specify any database schema changes and their impact.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Note added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • NEWS: Ensure that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

Learning and Resources (if applicable)

Screenshots (if applicable)

@azizbekxm azizbekxm marked this pull request as ready for review January 23, 2024 12:49
@azizbekxm azizbekxm requested a review from a team as a code owner January 23, 2024 12:49
psmagin
psmagin requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azizbekxm, please

  1. follow PR template https://github.com/folio-org/mod-inventory-storage/blob/master/PULL_REQUEST_TEMPLATE.md
  2. Update version of the related API
  3. Update NEWS

@azizbekxm azizbekxm requested a review from psmagin January 24, 2024 11:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azizbekxm azizbekxm merged commit 71504b0 into master Jan 25, 2024
6 checks passed
@azizbekxm azizbekxm deleted the MODINVSTOR-1154-2 branch January 25, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin psmagin approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@TsaghikKhachatryan TsaghikKhachatryan Awaiting requested review from TsaghikKhachatryan TsaghikKhachatryan is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@GeloPakDev1 GeloPakDev1 Awaiting requested review from GeloPakDev1 GeloPakDev1 is a code owner automatically assigned from folio-org/spitfire-backend

@Dmitriy-Butramyou Dmitriy-Butramyou Awaiting requested review from Dmitriy-Butramyou

@Abdulkhakimov Abdulkhakimov Awaiting requested review from Abdulkhakimov

@imerabishvili imerabishvili Awaiting requested review from imerabishvili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azizbekxm @psmagin @SerhiiNosko