Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODINV-1029] Declare an interface to update ownership of Holdings and Items #725

Merged
merged 6 commits into from
Jun 5, 2024
Merged

[MODINV-1029] Declare an interface to update ownership of Holdings and Items #725

merged 6 commits into from
Jun 5, 2024

Conversation

RomanChernetskyi
Copy link
Contributor

@RomanChernetskyi RomanChernetskyi commented May 24, 2024 •
edited
Loading

Purpose

Declare an interface to update ownership of Holdings and Items

Approach

  1. Declare an interface “inventory-update-ownership” in ModuleDescriptor

  2. Declare 2 endpoints:

  • /inventory/holdings/update-ownership
  • /inventory/items/update-ownership
  1. Add request schemas:
  • holdings-update-ownership.json with properties: toInstanceId (UUID), holdingsRecordIds (array of UUIDs), targetTenantId (string)
  • items-update-ownership.json with properties: toHoldingsRecordId (UUID), itemIds (array of UUIDs), targetTenantId (string)

  1. Define raml file for the 2 declared endpoints. Use move-response.json to define successful response

  2. Add unit tests (Ignored until implementation done)

KaterynaSenchenko
KaterynaSenchenko reviewed May 27, 2024
View reviewed changes
descriptors/ModuleDescriptor-template.json Outdated Show resolved Hide resolved
descriptors/ModuleDescriptor-template.json Outdated Show resolved Hide resolved
descriptors/ModuleDescriptor-template.json Outdated Show resolved Hide resolved
ramls/holdings_update_ownership.json Outdated Show resolved Hide resolved
ramls/holdings_update_ownership.json Outdated Show resolved Hide resolved
@RomanChernetskyi RomanChernetskyi requested a review from VRohach June 5, 2024 06:39
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@RomanChernetskyi RomanChernetskyi merged commit e8d11c0 into master Jun 5, 2024
6 checks passed
@RomanChernetskyi RomanChernetskyi deleted the MODINV-1029 branch June 5, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuslanLavrov RuslanLavrov RuslanLavrov approved these changes

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@VRohach VRohach VRohach approved these changes

@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk approved these changes

@dmytrokrutii dmytrokrutii Awaiting requested review from dmytrokrutii

@JavokhirAbdullayev JavokhirAbdullayev Awaiting requested review from JavokhirAbdullayev

@Maksat-Galymzhan Maksat-Galymzhan Awaiting requested review from Maksat-Galymzhan

@okolawole-ebsco okolawole-ebsco Awaiting requested review from okolawole-ebsco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RomanChernetskyi @Aliaksandr-Fedasiuk @VRohach @KaterynaSenchenko @RuslanLavrov