feat(instance-date-type-fields): add new date type fields to Instance schema #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvitlanaKovalova1
requested review from
PBobylev,
azizbekxm,
marcjohnson-kint,
psmagin,
viacheslavkol,
mukhiddin-yusuf and
viacheslavpoliakov
|
@SvitlanaKovalova1 Thank you for the invite to review I am no longer actively involved in inventory development within FOLIO What feedback would you like from me regarding this change? |
psmagin
approved these changes
Aug 30, 2024
Hi @marcjohnson-kint, your username was on the list of supposed PR approvers, so I invited you to review. Sorry for the inconvenience, you can ignore this PR. |
viacheslavkol
approved these changes
Aug 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
MODINV-1067 Currently in the Instance schema, there is a field for publication date. However, this data originates from an uncontrolled string in variable fields of the MARC record. The dates in the 008 are more consistently formatted, and are more useful for certain materials like serials. Previously, we implemented sortable properties (publicationPeriod.start/publicationPeriod.end) that are parsed from the publication date field. We need to break this relationship, and instead make the source of that data the elements from the 008. The 008 structure allows for a single position to indicate the type of date that will be represented in the following positions.
Approach