Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINV-1125: Fix handling Optimistic Locking error and retry mechanism on Instance update #799

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

MODINV-1125: Fix handling Optimistic Locking error and retry mechanism on Instance update #799

wants to merge 4 commits into from

Conversation

mukhiddin-yusuf
Copy link
Contributor

@mukhiddin-yusuf mukhiddin-yusuf commented Jan 9, 2025 •
edited
Loading

Purpose

Fix handling optimistic locking error on updating inventory instance record while handling Marc Bib Update event and implement proper retry mechanism

Approach

Do not wrap OptimisticLocking error inside the other one so that it is possible to handle it in the Marc Bib update event handler

Changes Checklist

  • Logging: Confirm that logging is appropriately handled.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • Integration Testing: Confirm the logic in covered by integration testing

MODINV-1125

@mukhiddin-yusuf mukhiddin-yusuf requested a review from a team January 9, 2025 11:36
@mukhiddin-yusuf mukhiddin-yusuf self-assigned this Jan 9, 2025
@mukhiddin-yusuf mukhiddin-yusuf requested review from psmagin, viacheslavkol and SvitlanaKovalova1 and removed request for a team January 9, 2025 11:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
59.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin Awaiting requested review from psmagin psmagin was automatically assigned from folio-org/spitfire-backend

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol was automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 was automatically assigned from folio-org/spitfire-backend

Assignees

@mukhiddin-yusuf mukhiddin-yusuf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mukhiddin-yusuf