Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODORDERS-853: VertxFutureRepeater.repeat failure handling #1008

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

julianladisch
Copy link
Contributor

@julianladisch julianladisch commented Aug 30, 2024

https://folio-org.atlassian.net/browse/MODORDERS-853

Purpose

Fix broken exception reporting of VertxFutureRepeater.

Approach

Replace onFailure with recover.

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

@julianladisch julianladisch requested a review from a team August 30, 2024 16:20
Copy link

@julianladisch julianladisch merged commit c5fd992 into master Sep 2, 2024
6 checks passed
@julianladisch julianladisch deleted the MODORDERS-853-VertxFutureRepeater branch September 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants