MODORDERS-853: VertxFutureRepeater.repeat failure handling #1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODORDERS-853
Purpose
Fix broken exception reporting of VertxFutureRepeater.
Approach
Replace onFailure with recover.
Learning
<exclude>org/folio/rest/impl/**Test.class</exclude>
,<include>org/folio/ApiTestSuite.java</include>
,<include>org/folio/DataImportTestSuite.java</include>
for maven-surefire-plugin is very (!) error-prone because nobody notices when a new test class is not added to any test suite. There are much better ways to share a common setup, for example a test base with a singleton: https://java.testcontainers.org/test_framework_integration/manual_lifecycle_control/#singleton-containers Or an extension: https://github.com/folio-org/folio-spring-support/tree/master/folio-spring-testing/src/main/java/org/folio/spring/testing/extension/implPre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.