Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODORDERS-1185]. Encumbrance amount does not update when exchange rate is edited on open order #1018

Closed
wants to merge 2 commits into from
Closed

[MODORDERS-1185]. Encumbrance amount does not update when exchange rate is edited on open order #1018

wants to merge 2 commits into from

Conversation

BKadirkhodjaev
Copy link
Contributor

@BKadirkhodjaev BKadirkhodjaev commented Sep 16, 2024 •
edited
Loading

Purpose

Approach

  • Add exchange value validation on POL exchange rate update
  • Covers multiples cases:
    • Dynamic exchange -> Manual exchange rate
    • Manual exchange rate -> Manual exchange rate
    • Manual exchange rate -> Dynamic exchange rate
    • No exchange rate -> Manual/dynamic exchange rate
  • Tested by unit tests, current mod-orders & cross module tests, and additional cross-module tests

@BKadirkhodjaev BKadirkhodjaev requested a review from a team September 16, 2024 12:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BKadirkhodjaev BKadirkhodjaev changed the title [MODORDERS-1185]. Encumbrance amount does not update when exchange ra… [MODORDERS-1185]. Encumbrance amount does not update when exchange rate is edited on open order Sep 16, 2024
@BKadirkhodjaev BKadirkhodjaev deleted the MODORDERS-1162 branch September 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BKadirkhodjaev