Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODORDERS-1209-2]. Update Send Claims and Piece Batch Update models with new properties #1070

Merged
merged 10 commits into from
Dec 20, 2024
Merged

[MODORDERS-1209-2]. Update Send Claims and Piece Batch Update models with new properties #1070

merged 10 commits into from
Dec 20, 2024

Conversation

BKadirkhodjaev
Copy link
Contributor

@BKadirkhodjaev BKadirkhodjaev commented Dec 18, 2024 •
edited
Loading

Purpose

Approach

  • Add extra properties to Send Claims (claiming interval, internalNote & externalNote) for saving
  • Add extra property (claiming interval) to Piece Batch Update for saving
  • Additional changes:
    • Change validation responses to throw an HTTP exception with code, message and parameters populated
    • Move all claiming-related error messages into ErrorCodes enum
    • Switch places between calls, making jobs creation happen before pieces update
    • Add tenant validation on Integration Details retrieval

@BKadirkhodjaev BKadirkhodjaev marked this pull request as ready for review December 19, 2024 16:54
@BKadirkhodjaev BKadirkhodjaev requested a review from a team December 19, 2024 21:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BKadirkhodjaev BKadirkhodjaev merged commit 8ab6e5d into master Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azizbekxm azizbekxm azizbekxm approved these changes

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BKadirkhodjaev @SerhiiNosko @azizbekxm