-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODORDSTOR-356] - Initial setup of claiming batch job #793
Conversation
Kudos, SonarCloud Quality Gate passed! |
Piece.ReceivingStatus receivingStatusStorage = pieceStorage.getReceivingStatus(); | ||
boolean isReceivingStatusChanged = receivingStatusStorage.compareTo(receivingStatusUpdate) != 0; | ||
|
||
if(isReceivingStatusChanged) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add info log here that can help us in troubleshooting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have loggin statements in #L138 and #L139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically they are with debug level and basically separate log that include pieceId and both statuses(from and to) would be useful expessionally if we have logic with conditional statements, but it up to you
Purpose
Forgot to point out a couple places to update the date of the status change in the previous PR: #791 .
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.