-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODORDERS-1010] - Change "caption" to "Display summary" for checkin and receiving collections #826
Conversation
2e0991d
to
6083463
Compare
@@ -366,7 +366,7 @@ | |||
}, | |||
{ | |||
"id": "receiving", | |||
"version": "1.2", | |||
"version": "2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we should update in requires section to new version of receiving-history interface from 3.2 to 4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provided pieces API version also should be increased from 2.1 to 3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then probably we require pieces 5.0 instead of 4.0. Fixed
c45c3e1
to
3151f15
Compare
3151f15
to
53575bd
Compare
…and receiving collections
53575bd
to
6ff6fbe
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Purpose
https://issues.folio.org/browse/MODORDERS-1000
Approach
Update field name across the module
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.