MODSOURMAN-1085 MARC record with a 100 tag without a $a is being disc…

…arded on import. (#832) * mark a subfield as required in some rules * fix tests * update news * order matters, move name to top in an array * fix tests
folio-org · Dec 7, 2023 · 241ac21 · 241ac21
1 parent 40b2b10
commit 241ac21
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 96 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,5 @@
 ## 2023-xx-xx v3.8.0-SNAPSHOT
+* [MODSOURMAN-1085](https://issues.folio.org/browse/MODSOURMAN-1085) MARC record with a 100 tag without a $a is being discarded on import.
 * [MODSOURMAN-1030](https://issues.folio.org/browse/MODSOURMAN-1030) The number of updated records is not correct displayed in the 'SRS Marc' column in the 'Log summary' table
 * [MODSOURMAN-976](https://issues.folio.org/browse/MODSOURMAN-976) Incorrect error counts
 * [MODSOURMAN-1093](https://issues.folio.org/browse/MODSOURMAN-1093) EventHandlingUtil hangs forever on error

diff --git a/mod-source-record-manager-server/src/main/resources/rules/marc_bib_rules.json b/mod-source-record-manager-server/src/main/resources/rules/marc_bib_rules.json
@@ -1113,6 +1113,37 @@
   "100": [
     {
       "entity": [
+        {
+          "target": "contributors.name",
+          "description": "Personal Name",
+          "subfield": [
+            "a",
+            "b",
+            "c",
+            "d",
+            "f",
+            "g",
+            "j",
+            "k",
+            "l",
+            "n",
+            "p",
+            "q",
+            "t",
+            "u"
+          ],
+          "requiredSubfield": ["a"],
+          "applyRulesOnConcatenatedData": true,
+          "rules": [
+            {
+              "conditions": [
+                {
+                  "type": "trim_punctuation"
+                }
+              ]
+            }
+          ]
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1181,26 +1212,31 @@
               "value": "true"
             }
           ]
-        },
+        }
+      ]
+    }
+  ],
+  "110": [
+    {
+      "entity": [
         {
           "target": "contributors.name",
-          "description": "Personal Name",
+          "description": "Corporate Name",
           "subfield": [
             "a",
             "b",
             "c",
             "d",
             "f",
             "g",
-            "j",
             "k",
             "l",
             "n",
             "p",
-            "q",
             "t",
             "u"
           ],
+          "requiredSubfield": ["a"],
           "applyRulesOnConcatenatedData": true,
           "rules": [
             {
@@ -1211,13 +1247,7 @@
               ]
             }
           ]
-        }
-      ]
-    }
-  ],
-  "110": [
-    {
-      "entity": [
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1286,10 +1316,16 @@
               "value": "true"
             }
           ]
-        },
+        }
+      ]
+    }
+  ],
+  "111": [
+    {
+      "entity": [
         {
           "target": "contributors.name",
-          "description": "Corporate Name",
+          "description": "Meeting Name",
           "subfield": [
             "a",
             "b",
@@ -1304,6 +1340,7 @@
             "t",
             "u"
           ],
+          "requiredSubfield": ["a"],
           "applyRulesOnConcatenatedData": true,
           "rules": [
             {
@@ -1314,13 +1351,7 @@
               ]
             }
           ]
-        }
-      ]
-    }
-  ],
-  "111": [
-    {
-      "entity": [
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1389,34 +1420,6 @@
               "value": "true"
             }
           ]
-        },
-        {
-          "target": "contributors.name",
-          "description": "Meeting Name",
-          "subfield": [
-            "a",
-            "b",
-            "c",
-            "d",
-            "f",
-            "g",
-            "k",
-            "l",
-            "n",
-            "p",
-            "t",
-            "u"
-          ],
-          "applyRulesOnConcatenatedData": true,
-          "rules": [
-            {
-              "conditions": [
-                {
-                  "type": "trim_punctuation"
-                }
-              ]
-            }
-          ]
         }
       ]
     }

diff --git a/mod-source-record-manager-server/src/test/resources/org/folio/services/marc_bib_rules.json b/mod-source-record-manager-server/src/test/resources/org/folio/services/marc_bib_rules.json
@@ -1113,6 +1113,37 @@
   "100": [
     {
       "entity": [
+        {
+          "target": "contributors.name",
+          "description": "Personal Name",
+          "subfield": [
+            "a",
+            "b",
+            "c",
+            "d",
+            "f",
+            "g",
+            "j",
+            "k",
+            "l",
+            "n",
+            "p",
+            "q",
+            "t",
+            "u"
+          ],
+          "requiredSubfield": ["a"],
+          "applyRulesOnConcatenatedData": true,
+          "rules": [
+            {
+              "conditions": [
+                {
+                  "type": "trim_punctuation"
+                }
+              ]
+            }
+          ]
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1181,26 +1212,31 @@
               "value": "true"
             }
           ]
-        },
+        }
+      ]
+    }
+  ],
+  "110": [
+    {
+      "entity": [
         {
           "target": "contributors.name",
-          "description": "Personal Name",
+          "description": "Corporate Name",
           "subfield": [
             "a",
             "b",
             "c",
             "d",
             "f",
             "g",
-            "j",
             "k",
             "l",
             "n",
             "p",
-            "q",
             "t",
             "u"
           ],
+          "requiredSubfield": ["a"],
           "applyRulesOnConcatenatedData": true,
           "rules": [
             {
@@ -1211,13 +1247,7 @@
               ]
             }
           ]
-        }
-      ]
-    }
-  ],
-  "110": [
-    {
-      "entity": [
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1286,10 +1316,16 @@
               "value": "true"
             }
           ]
-        },
+        }
+      ]
+    }
+  ],
+  "111": [
+    {
+      "entity": [
         {
           "target": "contributors.name",
-          "description": "Corporate Name",
+          "description": "Meeting Name",
           "subfield": [
             "a",
             "b",
@@ -1304,6 +1340,7 @@
             "t",
             "u"
           ],
+          "requiredSubfield": ["a"],
           "applyRulesOnConcatenatedData": true,
           "rules": [
             {
@@ -1314,13 +1351,7 @@
               ]
             }
           ]
-        }
-      ]
-    }
-  ],
-  "111": [
-    {
-      "entity": [
+        },
         {
           "target": "contributors.authorityId",
           "description": "Authority ID that controlling the contributor",
@@ -1389,34 +1420,6 @@
               "value": "true"
             }
           ]
-        },
-        {
-          "target": "contributors.name",
-          "description": "Meeting Name",
-          "subfield": [
-            "a",
-            "b",
-            "c",
-            "d",
-            "f",
-            "g",
-            "k",
-            "l",
-            "n",
-            "p",
-            "t",
-            "u"
-          ],
-          "applyRulesOnConcatenatedData": true,
-          "rules": [
-            {
-              "conditions": [
-                {
-                  "type": "trim_punctuation"
-                }
-              ]
-            }
-          ]
         }
       ]
     }