-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODSOURMAN-1022: remove step of initial saving of incoming records to SRS #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslav-epam
requested review from
Aliaksandr-Fedasiuk,
tatsiana-tarhonskaya,
VRohach,
RuslanLavrov,
JavokhirAbdullayev,
RomanChernetskyi and
Maksat-Galymzhan
November 16, 2023 14:28
yaroslav-epam
force-pushed
the
UXPROD-4471
branch
from
November 21, 2023 09:31
6a1a56b
to
e3732fa
Compare
yaroslav-epam
force-pushed
the
MODSOURMAN-1022
branch
4 times, most recently
from
November 24, 2023 10:40
0c377a7
to
ec45a0a
Compare
Maksat-Galymzhan
approved these changes
Nov 27, 2023
VRohach
approved these changes
Nov 27, 2023
mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java
Outdated
Show resolved
Hide resolved
mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java
Outdated
Show resolved
Hide resolved
mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java
Outdated
Show resolved
Hide resolved
yaroslav-epam
force-pushed
the
MODSOURMAN-1022
branch
from
November 27, 2023 11:58
ec45a0a
to
4db76c2
Compare
mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java
Outdated
Show resolved
Hide resolved
...ger-server/src/test/java/org/folio/verticle/consumers/RawMarcChunkConsumersVerticleTest.java
Outdated
Show resolved
Hide resolved
yaroslav-epam
force-pushed
the
MODSOURMAN-1022
branch
2 times, most recently
from
November 28, 2023 13:00
5be3f34
to
9dbd687
Compare
Aliaksandr-Fedasiuk
approved these changes
Nov 28, 2023
mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java
Outdated
Show resolved
Hide resolved
yaroslav-epam
force-pushed
the
MODSOURMAN-1022
branch
from
November 28, 2023 16:09
9dbd687
to
6180a79
Compare
yaroslav-epam
force-pushed
the
MODSOURMAN-1022
branch
from
November 28, 2023 16:30
6180a79
to
e0238f4
Compare
Kudos, SonarCloud Quality Gate passed! |
RuslanLavrov
approved these changes
Nov 28, 2023
yaroslav-epam
added a commit
that referenced
this pull request
Dec 13, 2023
yaroslav-epam
added a commit
that referenced
this pull request
Jan 4, 2024
yaroslav-epam
added a commit
that referenced
this pull request
Jan 15, 2024
yaroslav-epam
added a commit
that referenced
this pull request
Jan 19, 2024
* MODSOURMAN-1021: add endpoint to get IncomingRecord by id with DAO and service layers functionality (#823) * MODSOURMAN-1022: remove step of initial saving of incoming records to SRS (#826) * MODSOURMAN-1070: Fill in Journal Records for created MARC when INSTANCE_CREATED event received (#834) * MODSOURMAN-1070: Filled in two journals records for Instance and Marc bib during INSTANCE_CREATED event type * MODSOURMAN-1063: remove entity type set for journal records to not fetch them with get_job_log_entries (#844) * MODSOURMAN-1063: Update RecordProcessingLogDto to contain incoming record id --------- Co-authored-by: Yaroslav_Kiriak <[email protected]> Co-authored-by: Maksat <[email protected]> Co-authored-by: Volodymyr Rohach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove step of initial saving of incoming records to SRS
Approach
Removing step of initial saving of incoming records to SRS and using
RecordsPublishingServiceImpl
to send events intoDI_INCOMING_EDIFACT_RECORD_PARSED
andDI_INCOMING_MARC_BIB_RECORD_PARSED
topicsMODSOURMAN-1022