Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODDATAIMP-957: remove initial saving of records in SRS #845

Merged
merged 8 commits into from
Jan 19, 2024
Merged

MODDATAIMP-957: remove initial saving of records in SRS #845

merged 8 commits into from
Jan 19, 2024

Conversation

yaroslav-epam
Copy link
Contributor

@yaroslav-epam yaroslav-epam commented Jan 18, 2024 •
edited
Loading

Purpose

Remove initial saving of records in SRS

Blocked by: #838

Approach

How does this change fulfill the purpose?

Is this change testable? If not - why?

Checklist

  • I have updated NEWS.md.
  • I have added javadocs to new methods.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation e.g. README.md.
  • I have ran karate tests against this feature.

yaroslav-epam and others added 6 commits January 15, 2024 16:59
VRohach and others added 2 commits January 18, 2024 17:27
@VRohach @yaroslav-epam @Maksat-Galymzhan
MODSOURAMN-1063 - Update RecordProcessingLogDto to contain incoming r…
63b787d 
…ecord id (#838)

* MODSOURMAN-1063: Update RecordProcessingLogDto to contain incoming record id
---------

Co-authored-by: Yaroslav_Kiriak <[email protected]>
Co-authored-by: Maksat <[email protected]>
@yaroslav-epam
MODSOURMAN-1063: adjust recordProcessingLogDto.json and add recordPro…
6d418bf 
…cessingLogDtoCollection.json schema (#304)
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

10 New issues
0 Security Hotspots
94.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yaroslav-epam yaroslav-epam merged commit 84315dc into master Jan 19, 2024
8 checks passed
@yaroslav-epam yaroslav-epam deleted the UXPROD-4471 branch January 19, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk approved these changes

@RuslanLavrov RuslanLavrov Awaiting requested review from RuslanLavrov

@JavokhirAbdullayev JavokhirAbdullayev Awaiting requested review from JavokhirAbdullayev

@RomanChernetskyi RomanChernetskyi Awaiting requested review from RomanChernetskyi

@Maksat-Galymzhan Maksat-Galymzhan Awaiting requested review from Maksat-Galymzhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yaroslav-epam @Aliaksandr-Fedasiuk @KaterynaSenchenko @Maksat-Galymzhan @VRohach