Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODSOURCE-733: raml-storage dependency updated. #909

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

VRohach
Copy link
Contributor

@VRohach VRohach commented May 29, 2024

Purpose

Describe the purpose of the pull request. Include background information if necessary.

Approach

How does this change fulfill the purpose?

Is this change testable? If not - why?

Checklist

  • I have updated NEWS.md.
  • I have added javadocs to new methods.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation e.g. README.md.
  • I have ran karate tests against this feature.

import org.folio.rest.jaxrs.model.ProfileSnapshotWrapper;
import org.folio.rest.jaxrs.model.RawRecordsDto;
import org.folio.rest.jaxrs.model.StatusDto;
import org.folio.rest.jaxrs.model.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use single class import instead of wild card import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maksat-Galymzhan Thank you! It seems like after updating IntelliJIdea this setting was removed. Fixed.

@@ -27,7 +21,7 @@
import java.util.List;
import java.util.Map;

import static org.folio.rest.jaxrs.model.ProfileSnapshotWrapper.ContentType.*;
import static org.folio.rest.jaxrs.model.ProfileType.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link

@VRohach VRohach merged commit e29f875 into master May 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants