Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODSOURMAN-1232 Add the option to exclude job profile names to GET "/metadata-provider/jobExecutions" endpoint #937

Merged
merged 7 commits into from
Oct 15, 2024
Merged

MODSOURMAN-1232 Add the option to exclude job profile names to GET "/metadata-provider/jobExecutions" endpoint #937

merged 7 commits into from
Oct 15, 2024

Conversation

JavokhirAbdullayev
Copy link
Contributor

@JavokhirAbdullayev JavokhirAbdullayev commented Oct 11, 2024 •
edited
Loading

Purpose

MODSOURMAN-1232 Add the option to exclude job profile names to GET "/metadata-provider/jobExecutions" endpoint

Approach

add new query param to endpoint

Is this change testable? If not - why?

Checklist

  • I have updated NEWS.md.
  • I have added javadocs to new methods.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation e.g. README.md.
  • I have ran karate tests against this feature.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JavokhirAbdullayev JavokhirAbdullayev merged commit 2c4be97 into master Oct 15, 2024
8 checks passed
@JavokhirAbdullayev JavokhirAbdullayev deleted the MODSOURMAN-1232 branch October 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuslanLavrov RuslanLavrov RuslanLavrov approved these changes

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko left review comments

@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk approved these changes

@VRohach VRohach Awaiting requested review from VRohach

@dmytrokrutii dmytrokrutii Awaiting requested review from dmytrokrutii

@RomanChernetskyi RomanChernetskyi Awaiting requested review from RomanChernetskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JavokhirAbdullayev @Aliaksandr-Fedasiuk @KaterynaSenchenko @RuslanLavrov