Fixed sonar smells

folio-org · Feb 7, 2024 · 9480560 · 9480560
1 parent 4f48dec
commit 9480560
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDao.java b/mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDao.java
@@ -89,7 +89,7 @@ public interface RecordDao {
 
   /**
    * Searches for {@link Record} by {@link MatchField} with offset and limit,
-   * and returns {@link RecordsIdentifiersCollection} representing list of pairs of recordsId and externalId
+   * and returns {@link RecordsIdentifiersCollection} representing list of pairs of recordId and externalId
    *
    * @param matchedField        describes searching condition
    * @param returnTotalRecords  indicates that amount of total records should/shouldn't be calculated

diff --git a/mod-source-record-storage-server/src/main/java/org/folio/services/RecordService.java b/mod-source-record-storage-server/src/main/java/org/folio/services/RecordService.java
@@ -160,7 +160,7 @@ public interface RecordService {
 
   /**
    * Searches for {@link Record} by condition specified in {@link RecordMatchingDto}
-   * and returns {@link RecordsIdentifiersCollection} representing list of pairs of recordsId and externalId
+   * and returns {@link RecordsIdentifiersCollection} representing list of pairs of recordId and externalId
    *
    * @param recordMatchingDto record matching request that describes matching criteria
    * @param tenantId          tenant id

diff --git a/mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java b/mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java
@@ -115,7 +115,7 @@ public Future<Optional<Record>> getRecordById(String id, String tenantId) {
 
   @Override
   public Future<Record> saveRecord(Record record, String tenantId) {
-    LOG.debug(format("saveRecord:: Saving record with id: %s for tenant: %s", record.getId(), tenantId));
+    LOG.debug("saveRecord:: Saving record with id: {} for tenant: {}", record.getId(), tenantId);
     ensureRecordHasId(record);
     ensureRecordHasSuppressDiscovery(record);
     return recordDao.executeInTransaction(txQE -> SnapshotDaoUtil.findById(txQE, record.getSnapshotId())
@@ -402,12 +402,12 @@ private void setMatchedIdFromExistingSourceRecord(Record record, String tenantId
           if (sourceRecord.isPresent()) {
             // Set matched id from existing source record
             String sourceRecordId = sourceRecord.get().getRecordId();
-            LOG.debug(format("setMatchedIdFromExistingSourceRecord:: Set matchedId: %s from source record for record with id: %s",
-              sourceRecordId, record.getId()));
+            LOG.debug("setMatchedIdFromExistingSourceRecord:: Set matchedId: {} from source record for record with id: {}",
+              sourceRecordId, record.getId());
             promise.complete(record.withMatchedId(sourceRecordId));
           } else {
             // Set matched id same as record id
-            LOG.debug(format("setMatchedIdFromExistingSourceRecord:: Set matchedId same as record id: %s", record.getId()));
+            LOG.debug("setMatchedIdFromExistingSourceRecord:: Set matchedId same as record id: {}", record.getId());
             promise.complete(record.withMatchedId(record.getId()));
           }
         } else {

diff --git a/...-storage-server/src/main/java/org/folio/services/caches/ConsortiumConfigurationCache.java b/...-storage-server/src/main/java/org/folio/services/caches/ConsortiumConfigurationCache.java
@@ -76,7 +76,7 @@ private CompletableFuture<? extends Optional<ConsortiumConfiguration>> loadConso
         } else {
           String message = String.format("Error loading consortiumConfiguration by tenantId: '%s', status code: %s, response message: %s",
             params.getTenantId(), httpResponse.getResponse().statusCode(), httpResponse.getBody());
-          LOGGER.warn(String.format("loadConsortiumConfiguration:: %s", message));
+          LOGGER.warn("loadConsortiumConfiguration:: {}", message);
           return CompletableFuture.failedFuture(new CacheLoadingException(message));
         }
       });