MODSOURCE-717: MARC modifications not processed when placed after Holdings Update action in a job profile #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maksat-Galymzhan
requested review from
Aliaksandr-Fedasiuk,
VRohach,
KaterynaSenchenko,
RuslanLavrov,
JavokhirAbdullayev,
RomanChernetskyi and
yaroslav-epam
Aliaksandr-Fedasiuk
approved these changes
Jan 8, 2024
RuslanLavrov
approved these changes
Jan 9, 2024
JavokhirAbdullayev
approved these changes
Jan 9, 2024
| @@ -42,6 +43,7 @@ public class DataImportConsumersVerticle extends AbstractConsumerVerticle { | |||
| DI_INVENTORY_AUTHORITY_CREATED_READY_FOR_POST_PROCESSING.value(), | |||
| DI_INVENTORY_AUTHORITY_UPDATED_READY_FOR_POST_PROCESSING.value(), | |||
| DI_INVENTORY_HOLDING_CREATED.value(), | |||
| DI_INVENTORY_HOLDING_UPDATED.value(), | |||
There was a problem hiding this comment.
What about DI_INVENTORY_ITEM_UPDATED? Do we need to add this subscription as well? For the case when Modify action is placed after the Update Item action
There was a problem hiding this comment.
It's already been added. DI_INVENTORY_ITEM_UPDATED.value(),
KaterynaSenchenko
approved these changes
Jan 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MARC modifications not processed when placed after Holdings Update action in a job profile.
Approach
ADDED holding update subscription. Also it is checked behavior with item case.