MODSOURCE-773: Remove default searching via "deleted"="false". #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be merged ONLY after folio-org/data-import-raml-storage#311 will be merged! |
…rd-storage into MODSOURCE-773 # Conflicts: # mod-source-record-storage-server/src/main/java/org/folio/services/RecordSearchParameters.java # mod-source-record-storage-server/src/test/java/org/folio/rest/impl/SourceStorageStreamApiTest.java
VRohach
requested review from
Aliaksandr-Fedasiuk,
KaterynaSenchenko,
RuslanLavrov,
JavokhirAbdullayev,
RomanChernetskyi,
Maksat-Galymzhan and
dmytrokrutii
JavokhirAbdullayev
approved these changes
Jun 5, 2024
KaterynaSenchenko
approved these changes
Jun 5, 2024
Maksat-Galymzhan
approved these changes
Jun 5, 2024
RuslanLavrov
approved these changes
Jun 5, 2024
dmytrokrutii
approved these changes
Jun 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The main goal is to remove default searching if "deleted" parameter is NOT set inside the request.It will find either deleted=true or deleted=false.
Approach
Schema changed+additional condition added - if isDeleted==null, then do not add a condition to the CQL query.
Test added.
Learning
https://folio-org.atlassian.net/browse/MODSOURCE-773