Extend MARC-MARC search query to account for qualifiers #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokrutii
changed the title
dmytrokrutii
requested review from
RuslanLavrov,
VRohach,
JavokhirAbdullayev,
Aliaksandr-Fedasiuk,
KaterynaSenchenko and
RomanChernetskyi
and removed request for
RuslanLavrov
| params.put("qualifier", getSqlQualifier(matchedField.getQualifierMatch())); | ||
| } | ||
| String sql; | ||
| Condition condition; |
There was a problem hiding this comment.
if condition is not used, let's remove it
There was a problem hiding this comment.
could you please also replace this line import static org.jooq.impl.DSL.*; with exact importing classes?
KaterynaSenchenko
approved these changes
Jul 26, 2024
RomanChernetskyi
approved these changes
Jul 29, 2024
RuslanLavrov
approved these changes
Jul 29, 2024
…RCE-783 # Conflicts: # NEWS.md
JavokhirAbdullayev
approved these changes
Jul 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enhance the implementation of the source-storage/records/matching endpoint to account for qualifiers when building a search query to get the record for matching.
TODOS and Open Questions
Learning
MODSOURCE-783