Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODSOURCE-752: Emit Domain Events For Source Records #635

Merged
merged 8 commits into from
Aug 7, 2024
Merged

MODSOURCE-752: Emit Domain Events For Source Records #635

merged 8 commits into from
Aug 7, 2024

Conversation

PBobylev
Copy link
Contributor

@PBobylev PBobylev commented Jul 25, 2024 •
edited
Loading

Purpose

MODSOURCE-752 Emit Domain Events For Source Records.

Approach

RecordDomainEventPublisher introduced to be triggered after each record(s) create/update operation in RecordDao.

TODOS and Open Questions

  • Discuss the approach with code owners
  • Add RAML definition for event DTO and use it
  • Handle all create/update methods in RecordDao
  • Implement configuration param for the module to enable/disable the publishing
  • Implement new topic creation
  • Fix/adapt existed tests
  • Cover new changes with tests

@PBobylev PBobylev self-assigned this Jul 25, 2024
@PBobylev PBobylev changed the title Emit Domain Events For Source Records MODSOURCE-752: Emit Domain Events For Source Records Jul 25, 2024
@PBobylev
Copy link
Contributor Author

Discussed with @KaterynaSenchenko, approach is approved and to be implemented.

@PBobylev PBobylev force-pushed the MODSOURCE-752 branch 3 times, most recently from cc63482 to a541282 Compare July 30, 2024 10:11
@PBobylev PBobylev force-pushed the MODSOURCE-752 branch 3 times, most recently from 24529a8 to bcee5f1 Compare August 1, 2024 09:21
@PBobylev PBobylev force-pushed the MODSOURCE-752 branch 2 times, most recently from 4c50759 to 01bfd9c Compare August 1, 2024 12:34
@PBobylev PBobylev marked this pull request as ready for review August 1, 2024 12:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PBobylev PBobylev merged commit bc5f800 into master Aug 7, 2024
6 checks passed
@PBobylev PBobylev deleted the MODSOURCE-752 branch August 7, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkjacob pkjacob pkjacob approved these changes

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@AndreiBordak AndreiBordak AndreiBordak approved these changes

@askhat-abishev askhat-abishev Awaiting requested review from askhat-abishev

Assignees

@PBobylev PBobylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PBobylev @AndreiBordak @KaterynaSenchenko @pkjacob