Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODSOURCE-817: Fix data consistency in handling and updating Marc Bib records for links.instance-authority event #652

Merged
merged 26 commits into from
Dec 3, 2024

Conversation

mukhiddin-yusuf
Copy link
Contributor

@mukhiddin-yusuf mukhiddin-yusuf commented Nov 14, 2024

Purpose

Make the handler of instance-authority links events consistent so that no data is lost.

Approach

  • make the handling of events for instance-authority links such that no Marc Bib modifications are lost due to concurrent nature of processing the events
  • make sure the event first in order, sent by the producer and then received by the consumer/mod-srs, for the sequence of events received at the same time and containing the updates for the same bib records in each of those events from the sequence is handled first by persisting the changes of related bibs than the events coming later in order.

TODOS and Open Questions

  • Integration testing
  • Check logging.
  • Manual testing

Learning

MODSOURCE-817
MODINV-1100

…arc Bib records for links.instance-authority event

- make the handling of events for instance-authority links so that no Marc Bib modifications from are lost due to concurrent nature of handling events
- make sure the event of the first in a sequence of updates sent by the producer and then received by the consumer is handled before with persisting the changes of related bibs than the events produced/consumed later

Closes: MODSOURCE-817
# Conflicts:
#	mod-source-record-storage-server/src/main/java/org/folio/consumers/AuthorityLinkChunkKafkaHandler.java
#	mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDaoImpl.java
@mukhiddin-yusuf mukhiddin-yusuf self-assigned this Nov 14, 2024
@mukhiddin-yusuf mukhiddin-yusuf requested review from a team, psmagin, viacheslavkol and SvitlanaKovalova1 and removed request for a team November 21, 2024 12:25
@mukhiddin-yusuf mukhiddin-yusuf requested a review from a team November 25, 2024 14:30
@mukhiddin-yusuf mukhiddin-yusuf merged commit 43120f4 into master Dec 3, 2024
6 checks passed
@mukhiddin-yusuf mukhiddin-yusuf deleted the MODSOURCE-817 branch December 3, 2024 16:00
mukhiddin-yusuf added a commit that referenced this pull request Dec 27, 2024
… records for links.instance-authority event (#652)

- make the handling of events for instance-authority links so that no Marc Bib modifications from are lost due to concurrent nature of handling events
- make sure the event of the first in a sequence of updates sent by the producer and then received by the consumer is handled before with persisting the changes of related bibs than the events produced/consumed later

Closes: MODSOURCE-817
RuslanLavrov pushed a commit that referenced this pull request Dec 27, 2024
… records for links.instance-authority event (#652)

MODSOURCE-817: Fix data consistency in handling and updating Marc Bib records for links.instance-authority event

- make the handling of events for instance-authority links so that no Marc Bib modifications from are lost due to concurrent nature of handling events
- make sure the event of the first in a sequence of updates sent by the producer and then received by the consumer is handled before with persisting the changes of related bibs than the events produced/consumed later

Closes: MODSOURCE-817

(cherry picked from commit 43120f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants