Skip to content

Commit 05ab601

Browse files
MODTLR-9 incorporating review comments
1 parent 65a3b9b commit 05ab601

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/main/java/org/folio/controller/EcsTlrController.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public ResponseEntity<EcsTlr> getEcsTlrById(UUID requestId) {
3535

3636
@Override
3737
public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
38-
log.debug("postEcsTlr:: parameters ecsTlr: {}", ecsTlr);
38+
log.debug("postEcsTlr:: parameters ecsTlr: {}", () -> ecsTlr);
3939

4040
return ResponseEntity.status(CREATED).body(ecsTlrService.create(ecsTlr));
4141
}
@@ -44,7 +44,7 @@ public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
4444
public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
4545
log.debug("putEcsTlrById:: parameters requestId: {}, ecsTlr: {}", () -> requestId, () -> ecsTlr);
4646
boolean requestUpdated = ecsTlrService.update(requestId, ecsTlr);
47-
HttpStatus httpStatus = requestUpdated ? NO_CONTENT : NOT_FOUND;
47+
HttpStatus httpStatus = requestUpdated ? NO_CONTENT : NOT_FOUND;
4848

4949
return ResponseEntity.status(httpStatus).build();
5050
}
@@ -53,7 +53,7 @@ public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
5353
public ResponseEntity<Void> deleteEcsTlrById(UUID requestId) {
5454
log.debug("deleteEcsTlrById:: parameters requestId: {}", requestId);
5555
boolean requestDeleted = ecsTlrService.delete(requestId);
56-
HttpStatus httpStatus = requestDeleted ? NO_CONTENT : NOT_FOUND;
56+
HttpStatus httpStatus = requestDeleted ? NO_CONTENT : NOT_FOUND;
5757

5858
return ResponseEntity.status(httpStatus).build();
5959
}

src/main/resources/swagger.api/examples/EcsTlr.sample

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"requesterId": "4565999e-1994-4aab-9282-185731b4ce66",
55
"requestType": "Hold",
66
"requestLevel": "Title",
7-
"requestExpirationDate": "2024-01-01T23:11:00-00:00",
8-
"requestDate": "2024-01-01T00:12:00-00:00"
7+
"requestExpirationDate": "2024-01-01T23:11:00+00:00",
8+
"requestDate": "2024-01-01T00:12:00+00:00"
99
"patronComments": "test comment",
1010
"fulfillmentPreference": "Hold Shelf",
1111
"pickupServicePointId": "71ff4b72-70a0-40f6-9f73-6db29ced80a3"

0 commit comments

Comments
 (0)