RANCHER-1961. Implement Configuration class (eHolgins, SMTP, reset password link) on Eureka. #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new class `Configurations` for handling tenant-specific configurations such as RMAPI, WorldCat, SMTP settings, and password reset links. This addition supports streamlined integration and management of these configurations using existing Kong and Keycloak services. Also includes methods for checking and setting these configurations.
…onfigurations, including SMTP, reset password links, eHolding and copycat.
epam-avramenko
requested review from
OHaimanov,
eldiiar-duishenaliev,
DmytrMoroz,
aatoyan,
yaroslavishchenko and
sergii-msn
aatoyan
approved these changes
Dec 23, 2024
|
|
||
| Constants.CONFIGURATIONS.smtpConfig.each { config -> | ||
| def content = context.readFile file: tools.copyResourceFileToCurrentDirectory("okapi/configurations/" + config) | ||
| String entries = new GStringTemplateEngine().createTemplate(content).make(binding).toString() |
There was a problem hiding this comment.
Why use template here?
| return this | ||
| } | ||
|
|
||
| @NonCPS |
There was a problem hiding this comment.
Can cause many problems....
OHaimanov
approved these changes
Dec 23, 2024
yaroslavishchenko
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.