UISACQCOMP-198: *BREAKING* useFilters - remove search term trimming.
#788
Conversation
Dmytro-Melnyshyn
requested review from
NikitaSedyx,
BogdanDenis,
usavkov-epam and
alisher-epam
|
Is it possible to not introduce a breaking change but configure the hook on how to behave with the search string via a configuration object or something? |
|
Yes, we can add a flag on whether to trim or not. However, it seems like this could be considered a bug. The cursor unexpectedly moving to the end of the search term when the first letter is removed is likely not the intended behavior, as it can disrupt the user's workflow and lead to confusion. |
| @@ -38,7 +38,7 @@ const useFilters = (resetData, initialFilters = {}) => { | |||
| ); | |||
|
|
|||
| const changeSearch = useCallback( | |||
| e => setSearchQuery(e.target.value?.trim()), | |||
| e => setSearchQuery(e.target.value), | |||
There was a problem hiding this comment.
hm, after this change we'll have issues with spaces, I don't think it's correct fix
There was a problem hiding this comment.
@NikitaSedyx - would it be acceptable to pass a flag to useFilters to be able to customize the trimming?
Purpose
Prevent a cursor shift when changing a search term.
Description
Currently, removing the first letter moves the cursor to the end of the search term, but should remain in the same place.
Currently: "E K245" -> "K245|"
After the PR is merged: "E K245" -> "| K245"
Remove search term trimming in the
changeSearchfunction to fix the cursor shift. However, this is a breaking change for Orders. It will be necessary to trim the query before making the fetch in ui-orders and retest this story UISACQCOMP-76.Issues
UISACQCOMP-198
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.
Screencast
2024-07-09_14h46_32.mp4