Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-212: Add isMultiSelect prop to DonorsLookup component #806

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mariia-aloshyna
Copy link
Contributor

Purpose

Add isMultiSelect prop to DonorsLookup component to make it optional. It is needed to support https://folio-org.atlassian.net/browse/UIDATIMP-1656

Approach

  • Add isMultiSelect prop to DonorsLookup component

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Aug 20, 2024

Jest Unit Test Statistics

    1 files  ±0  212 suites  ±0   3m 53s ⏱️ ±0s
534 tests ±0  532 ✔️ ±0  2 💤 ±0  0 ±0 
537 runs  ±0  535 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 46a47f8. ± Comparison against base commit 74abbe3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 20, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 46a47f8. ± Comparison against base commit 74abbe3.

♻️ This comment has been updated with latest results.

Copy link

@mariia-aloshyna mariia-aloshyna merged commit 88d54ed into master Aug 21, 2024
6 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UISACQCOMP-212 branch August 21, 2024 12:55
@usavkov-epam
Copy link
Contributor

@mariia-aloshyna please include someone from the Thunderjet team as a reviewer next time so that we understand the changes in the ACQ component library, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants