-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UISACQCOMP-215: ECS - Add isLoading
prop for holdings
#809
Conversation
@folio-org/fe-tl-reviewers ^^ review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alisher-epam
could you update changelog.md file and also address those couple of lint errors? I know the lint issues are not caused by your changes, but it is always good to clean them up.
isLoading
prop for holdingsisLoading
prop for holdings
Quality Gate passedIssues Measures |
Purpose
UISACQCOMP-215 -
isLoading
prop for holdings when fetching affiliation related locations to display loading indicatorApproach
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.