Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-215: ECS - Add isLoading prop for holdings #809

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

alisher-epam
Copy link
Contributor

@alisher-epam alisher-epam commented Aug 30, 2024

Purpose

UISACQCOMP-215 - isLoading prop for holdings when fetching affiliation related locations to display loading indicator

Approach

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

Copy link

github-actions bot commented Aug 30, 2024

Jest Unit Test Statistics

    1 files  ±0  212 suites  ±0   3m 53s ⏱️ -12s
534 tests ±0  532 ✔️ ±0  2 💤 ±0  0 ±0 
537 runs  ±0  535 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 89a360b. ± Comparison against base commit 60b4433.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 30, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 89a360b. ± Comparison against base commit 60b4433.

♻️ This comment has been updated with latest results.

@alisher-epam alisher-epam self-assigned this Aug 30, 2024
@alisher-epam alisher-epam requested review from usavkov-epam and a team August 30, 2024 13:10
@alisher-epam
Copy link
Contributor Author

@folio-org/fe-tl-reviewers ^^ review please

Copy link

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alisher-epam
could you update changelog.md file and also address those couple of lint errors? I know the lint issues are not caused by your changes, but it is always good to clean them up.

@alisher-epam alisher-epam requested a review from a team September 3, 2024 19:38
@alisher-epam alisher-epam changed the title Add isLoading prop for holdings UISACQCOMP-215: ECS - Add isLoading prop for holdings Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@alisher-epam alisher-epam merged commit 0862151 into master Sep 4, 2024
6 checks passed
@alisher-epam alisher-epam deleted the feature-loading branch September 4, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants