Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISACQCOMP-230 Move reusable version history components to the ACQ lib #831

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Nov 13, 2024

Purpose

https://folio-org.atlassian.net/browse/UISACQCOMP-230

Since the feature with the display of version history extends to other applications, a single source of common components for displaying versions and highlighting changed fields is required.

Approach

Based on the implementation of the feature in ui-orders, derive a set of common utilities and components.

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Jest Unit Test Statistics

    1 files  ±  0  222 suites  +3   4m 13s ⏱️ +13s
590 tests +12  588 ✔️ +12  2 💤 ±0  0 ±0 
593 runs  +12  591 ✔️ +12  2 💤 ±0  0 ±0 

Results for commit b161a69. ± Comparison against base commit 7f664e2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 13, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit b161a69. ± Comparison against base commit 7f664e2.

♻️ This comment has been updated with latest results.

@usavkov-epam usavkov-epam requested review from a team November 13, 2024 18:32
@usavkov-epam usavkov-epam merged commit 583d17e into master Nov 14, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UISACQCOMP-230 branch November 14, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants