UISACQCOMP-233: add useDebouncedQuery hook to fix endless request for DynamicSelection component
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amicSelection` component
SerhiiNosko
approved these changes
Nov 25, 2024
alisher-epam
changed the title
useDebouncedQuery hook to fix endless request for DynamicSelection componentuseDebouncedQuery hook to fix endless request for DynamicSelection component
UladzislauKutarkin
approved these changes
Nov 25, 2024
zburke
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Sonar is cranky about the lack of tests for useDebouncedQuery, and I think we have a CPM gotcha in there too. These issues need to be resolved.
My only other comment is that useDebouncedQuery is a generic name for the slightly more specific work that is happening in this hook. Maybe provide a default do-nothing implementation of dataFormatter as well if you want to keep this name?
Some documentation would be helpful too since returning the debounced input-setter as setInputValue, while clever, is not obvious at first glance.
Everything else looks good.
zburke
approved these changes
Nov 25, 2024
|
usavkov-epam
pushed a commit
that referenced
this pull request
Dec 4, 2024
…or `DynamicSelection` component (#834) * UIF-562: add `useDebouncedQuery` hook to fix endless request for `DynamicSelection` component * test: fix failing tests and update changelog file with correct Jira ticket number * test: add test coverages * refactor: rename hook outputs and add default formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UISACQCOMP-233: add
useDebouncedQueryhook to fix endless request forDynamicSelectioncomponentApproach
Screen.Recording.2024-11-25.at.17.55.10.mp4
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.