STCLI-221 handle access-control via cookies #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle access-control via access-token and refresh-token cookies instead of storing and passing the `X-Okapi-Token` HTTP request header. The AT is transparently refreshed when it expires as long as the RT is still valid. Replace node-fetch-npm with minipass-fetch, because it was there. Refs STCLI-221, FOLIO-3627, STCLI-214
JohnC-80
approved these changes
Oct 6, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle access-control via access-token and refresh-token cookies instead of storing and passing the
X-Okapi-TokenHTTP request header. The AT is transparently refreshed when it expires as long as the RT is still valid.Replace node-fetch-npm with minipass-fetch, because it was easy and I was in there and we meant to do this eons ago.
Refs STCLI-221, FOLIO-3627, STCLI-214