Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-745 bump stylelint to v15, and co-deps too #1344

Merged
merged 2 commits into from
Oct 3, 2023
Merged

STCOR-745 bump stylelint to v15, and co-deps too #1344

merged 2 commits into from
Oct 3, 2023

Conversation

zburke
Copy link
Member

@zburke zburke commented Sep 28, 2023

Bump stylelint to v15, stylelint-config-standard to v34. This allows us to avoid several transitive dependencies with security vulnerabilities reported by yarn audit.

The community config standard has evolved quite a bit since we first implemented this, necessitating turning off several warnings in .stylelintrc in order for code as-is to pass; see STCOR-746 for the details on removing these exceptions.

Refs STCOR-745

Bump `stylelint` to `v15`, `stylelint-config-standard` to `v34`. The
community config standard has evolved quite a bit since we first
implemented this, necessitating turning off several warnings in
`.stylelintrc` in order for code as-is to pass; see STCOR-746 for the
details on removing these exceptions.

Refs STCOR-745
@zburke zburke requested a review from JohnC-80 September 28, 2023 13:55
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Jest Unit Test Statistics

74 tests  ±0   74 ✔️ ±0   15s ⏱️ -2s
12 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit bfc70e2. ± Comparison against base commit 2fbe3ac.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   11s ⏱️ ±0s
271 tests ±0  266 ✔️ ±0  5 💤 ±0  0 ±0 
274 runs  ±0  269 ✔️ ±0  5 💤 ±0  0 ±0 

Results for commit bfc70e2. ± Comparison against base commit 2fbe3ac.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_117_0_0_0_(Linux_x86_64).Forgot username form test ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke zburke merged commit 4997ab8 into master Oct 3, 2023
5 checks passed
@zburke zburke deleted the STCOR-745 branch October 3, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants