Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-842 refactor away from deprecated getChildContext #1481

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

zburke
Copy link
Member

@zburke zburke commented May 24, 2024

getChildContext will be deprecated in React v19. AddContext can be eliminated completely; it duplicates the functionality offered by StripesContext.

Refs STCOR-842

`getChildContext` will be deprecated in React v19. `AddContext` can be
eliminated completely; it duplicates the functionality offered by
`StripesContext`.

Refs STCOR-842
@zburke zburke requested review from skomorokh and JohnC-80 May 24, 2024 02:43
Copy link

github-actions bot commented May 24, 2024

Jest Unit Test Statistics

207 tests  ±0   207 ✔️ ±0   46s ⏱️ -4s
  31 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 36c2c32. ± Comparison against base commit 05badf9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 24, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   11s ⏱️ ±0s
270 tests ±0  264 ✔️ ±0  6 💤 ±0  0 ±0 
273 runs  ±0  267 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 36c2c32. ± Comparison against base commit 05badf9.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 3, 2024

Jest Unit Test Results

228 tests  ±0   228 ✅ ±0   48s ⏱️ +2s
 36 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 600b982. ± Comparison against base commit 9d7cee9.

Copy link

github-actions bot commented Jun 3, 2024

Jest Unit Test Results

228 tests  ±0   228 ✅ ±0   47s ⏱️ -1s
 36 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 600b982. ± Comparison against base commit 9d7cee9.

Copy link

github-actions bot commented Jun 3, 2024

Bigtest Unit Test Results

193 tests  ±0   188 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 600b982. ± Comparison against base commit 9d7cee9.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zburke zburke merged commit d1cdfa8 into master Jun 3, 2024
25 of 26 checks passed
@zburke zburke deleted the STCOR-842 branch June 3, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants