STCOR-864 correctly evaluate typeof stripes.okapi #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripes should render `<ModuleContainer>` either when discovery is complete or when okapi isn't present at all, i.e. when `stripes.config.js` doesn't even contain an `okapi` entry. What's most amazing about this bug is not the bug, which is a relatively simple typo, but that it didn't bite us for more than six years. Refs STCOR-864
Bigtest Unit Test Results193 tests ±0 188 ✅ ±0 6s ⏱️ ±0s Results for commit 253227c. ± Comparison against base commit 8185c89. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
skomorokh
approved these changes
Jun 25, 2024
BTOG init never conducted discovery, but _did_ pass an okapi object during application setup, which is another way of saying that our application didn't have anything that relied on the presence of this bug, but our test suite did.
|
JohnC-80
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripes should render
<ModuleContainer>either when discovery is complete or when okapi isn't present at all, i.e. whenstripes.config.jsdoesn't even contain anokapientry. What's most amazing about this bug is not the bug, which is a relatively simple typo, but that it didn't bite us for more than six years.This bug was introduced in #153.
Refs STCOR-864