Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-890 useUserTenantPermissions hook - provide isFetched property #1538

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

BogdanDenis
Copy link
Contributor

Description

Is some cases it could be useful to provide isFetched in addition to isFetching, for example to differentiate if permissions had been loaded in the past, regardless if they are loading now or not

Issues

STCOR-890

Related PRs

folio-org/ui-inventory#2600

Copy link

github-actions bot commented Sep 23, 2024

Jest Unit Test Results

  1 files  ±0   56 suites  ±0   59s ⏱️ -3s
339 tests ±0  339 ✅ ±0  0 💤 ±0  0 ❌ ±0 
343 runs  ±0  343 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c4b4c0b. ± Comparison against base commit 61ff854.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Sep 23, 2024

Bigtest Unit Test Results

192 tests  ±0   187 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c4b4c0b. ± Comparison against base commit 61ff854.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_128_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_128_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_128_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_128_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_128_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@BogdanDenis BogdanDenis requested review from zburke and a team September 23, 2024 11:54
Copy link

@BogdanDenis BogdanDenis merged commit 181b42a into master Sep 24, 2024
26 checks passed
@BogdanDenis BogdanDenis deleted the STCOR-890 branch September 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants