STCOR-902 show error message on OIDC fetch failure #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When returning from a SAML/OIDC request, stripes makes an API request to exchange the token for cookies. If that API request fails, show an error and a button prompting the user to try authenticating again. Previously, instead of showing a button, stripes would automatically redirect to `/`, which (because there were no cookies) would redirect to the authentication URL, which (because there _were_ still valid authentication cookies) would redirect to stripes, starting an endless circle. Refs STCOR-902
Bigtest Unit Test Results192 tests ±0 187 ✅ ±0 6s ⏱️ ±0s Results for commit 4f248ae. ± Comparison against base commit 031a523. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both. |
|
aidynoJ
approved these changes
Nov 4, 2024
zburke
added a commit
that referenced
this pull request
Dec 2, 2024
When returning from a SAML/OIDC request, stripes makes an API request to exchange the token for cookies. If that API request fails, show an error and a button prompting the user to try authenticating again. Previously, instead of showing a button, stripes would automatically redirect to `/`, which (because there were no cookies) would redirect to the authentication URL, which (because there _were_ still valid authentication cookies) would redirect to stripes, starting an endless circle. Refs STCOR-902 (cherry picked from commit 8524811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning from a SAML/OIDC request, stripes makes an API request to exchange the token for cookies. If that API request fails, show an error and a button prompting the user to try authenticating again.
Previously, instead of showing a button, stripes would automatically redirect to
/, which (because there were no cookies) would redirect to the authentication URL, which (because there were still valid authentication cookies) would redirect to stripes, starting an endless circle.Refs STCOR-902