Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOR-882 return to previous location on logout-timeout #1558

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Nov 7, 2024

PR #1551 introduced a regression to the functionality added in STCOR-849/PR #1523. The correct behavior is for the logout button on the timeout page to point to the previous location, but after #1551 the button always pointed to /.

Refs STCOR-882, STCOR-849

PR #1551 introduced a regression to the functionality added in
STCOR-849/PR #1523. The correct behavior is for the logout button on the
timeout page to point to the previous locationk, but after #1551 the
button always pointed to `/`.

Refs STCOR-882, STCOR-849
Copy link

github-actions bot commented Nov 7, 2024

Bigtest Unit Test Results

192 tests  ±0   187 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9bb2113. ± Comparison against base commit 8524811.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_130_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_130_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_130_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_130_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_130_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

Copy link

github-actions bot commented Nov 7, 2024

Jest Unit Test Results

  1 files  ±0   55 suites  ±0   1m 32s ⏱️ ±0s
343 tests +3  343 ✅ +3  0 💤 ±0  0 ❌ ±0 
346 runs  +3  346 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 9bb2113. ± Comparison against base commit 8524811.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
Logout Timeout logout if authenticated, calls logout then renders a timeout message ‑ Logout Timeout logout if authenticated, calls logout then renders a timeout message
Logout Timeout logout if not authenticated, renders a timeout message ‑ Logout Timeout logout if not authenticated, renders a timeout message
Logout Direct logout "log in again" href points to "/" ‑ Logout Direct logout "log in again" href points to "/"
Logout Timeout logout if authenticated "login in again" href points to pre-timeout location ‑ Logout Timeout logout if authenticated "login in again" href points to pre-timeout location
Logout Timeout logout if authenticated calls logout then renders a timeout message ‑ Logout Timeout logout if authenticated calls logout then renders a timeout message
Logout Timeout logout if authenticated clicking "log in again" clears pre-timeout location from storage ‑ Logout Timeout logout if authenticated clicking "log in again" clears pre-timeout location from storage
Logout Timeout logout if not authenticated renders a timeout message ‑ Logout Timeout logout if not authenticated renders a timeout message

Copy link

sonarqubecloud bot commented Nov 7, 2024

@zburke zburke merged commit 0d65a69 into master Nov 11, 2024
16 checks passed
@zburke zburke deleted the STCOR-882-regression branch November 11, 2024 14:24
zburke added a commit that referenced this pull request Dec 2, 2024
PR #1551 introduced a regression to the functionality added in
STCOR-849/PR #1523. The correct behavior is for the logout button on the
timeout page to point to the previous location, but after #1551 the
button always pointed to `/`.

Refs STCOR-882, STCOR-849

(cherry picked from commit 0d65a69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants