STCOR-913 Don't override initial discovery and okapi data in test mocks #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e StrictMode in tests.
Bigtest Unit Test Results192 tests ±0 187 ✅ ±0 6s ⏱️ -1s Results for commit 1fbb033. ± Comparison against base commit 943d67a. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
BogdanDenis
force-pushed
the
dont-override-initial-okapi-data-in-tests
branch
from
ae4a6d0 to
51abc5b
Compare
zburke
changed the title
zburke
approved these changes
Nov 21, 2024
|
JohnC-80
approved these changes
Nov 21, 2024
zburke
pushed a commit
that referenced
this pull request
Dec 2, 2024
…ks (#1564) Updating `stripes-core` in SSC causes 30+ tests to fail. folio-org/stripes-smart-components#1538 This PR addresses some issues which cause these failures. Overwriting of initial okapi and discovery data in `setupApplication` helper. Some tests require custom okapi data, but `setupApplication` in some cases can overwrite that data which makes those tests fail. Still investigating a few failing tests so maybe there's something else that needs to be fixed. (cherry picked from commit 1c73afd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating
stripes-corein SSC causes 30+ tests to fail. folio-org/stripes-smart-components#1538This PR addresses some issues which cause these failures.
StrictMode. Using StrictMode makes components render twice to check for mutation, which makes some components receive test data twice, render twice etc. For now the fix is only hardcoded. Need to be able to passdisableStrictModeflag to karma tests<StrictMode>Addressed in STCLI-256 turn off StrictMode when running tests stripes-cli#363 instead.setupApplicationhelper. Some tests require custom okapi data, butsetupApplicationin some cases can overwrite that data which makes those tests fail.Refs STCOR-913