STCOR-906 consume react-query QueryClient in <Logout> #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly pass all three required arguments from `<Logout>` to `loginServices::logout()`: gateway URL, redux store, react-query QueryClient. The third was missing, resulting in an NPE during `logout()` that caused flow to skip to the `finally` clause, skipping the code that cleared localforage. Sometimes localforage appears to get cleared anyway, but sometimes not, in which case the session may fail to terminate even when the fixed-length session timer reaches 00:00. This is one of those "How did this ever work?!? And how did we not notice?!?" situations. Refs STCOR-906
Bigtest Unit Test Results192 tests ±0 187 ✅ ±0 6s ⏱️ ±0s Results for commit a969f5f. ± Comparison against base commit 1c73afd. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
aidynoJ
approved these changes
Nov 27, 2024
ryandberger
approved these changes
Nov 27, 2024
|
zburke
added a commit
that referenced
this pull request
Dec 2, 2024
Correctly pass all three required arguments from `<Logout>` to `loginServices::logout()`: gateway URL, redux store, react-query QueryClient. The third was missing, resulting in an NPE during `logout()` that caused flow to skip to the `finally` clause, skipping the code that cleared localforage. Sometimes localforage appears to get cleared anyway, but sometimes not, in which case the session may fail to terminate even when the fixed-length session timer reaches 00:00. This is one of those "How did this ever work?!? And how did we not notice?!?" situations. Refs [STCOR-906](https://folio-org.atlassian.net/browse/STCOR-906) (cherry picked from commit 9534433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly pass all three required arguments from
<Logout>tologinServices::logout(): gateway URL, redux store, react-query QueryClient. The third was missing, resulting in an NPE duringlogout()that caused flow to skip to thefinallyclause, skipping the code that cleared localforage. Sometimes localforage appears to get cleared anyway, but sometimes not, in which case the session may fail to terminate even when the fixed-length session timer reaches 00:00.This is one of those "How did this ever work?!? And how did we not notice?!?" situations.
Refs STCOR-906