STCOR-912 spread session, _self data when resuming session #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spread together existing session data with the response data from the `_self` endpoint. The latter may contain updated information such as new permissions, but it may also be sparsely populated, e.g. if the user has not selected a default service point but the active service point has been saved to the session. We take the union of the data, with the `_self` data overwriting matching values. Think of it like a bitwise-or. Refs STCOR-912
Bigtest Unit Test Results192 tests ±0 187 ✅ ±0 6s ⏱️ ±0s Results for commit a3dd57a. ± Comparison against base commit 1189bd5. This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Dmytro-Melnyshyn
approved these changes
Nov 28, 2024
|
JohnC-80
approved these changes
Dec 2, 2024
zburke
added a commit
that referenced
this pull request
Dec 2, 2024
Spread together existing session data with the response data from the `_self` endpoint. The latter may contain updated information such as new permissions, but it may also be sparsely populated, e.g. if the user has not selected a default service point but the active service point has been saved to the session. We take the union of the data, with the `_self` data overwriting matching values. Think of it like a bitwise-or. Refs [STCOR-912](https://folio-org.atlassian.net/browse/STCOR-912) (cherry picked from commit 4868456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spread together existing session data with the response data from the
_selfendpoint. The latter may contain updated information such as new permissions, but it may also be sparsely populated, e.g. if the user has not selected a default service point but the active service point has been saved to the session.We take the union of the data, with the
_selfdata overwriting matching values. Think of it like a bitwise-or.Refs STCOR-912