-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOR-941 Convert test suites to Newschool BT #1609
Draft
JohnC-80
wants to merge
2
commits into
master
Choose a base branch
from
STCOR-941
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+104
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bigtest Unit Test Results189 tests ±0 187 ✅ +3 9s ⏱️ +3s For more details on these failures, see this check. Results for commit 806b399. ± Comparison against base commit 0dadb81. This pull request removes 191 and adds 189 tests. Note that renamed tests count towards both.
This pull request removes 5 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of this was accomplished back when we 'jettisoned bigtest-mocha'. This PR cleans up the remainder of test suites still making use of old-school interactors. The interactors ARE still around to be ickily imported, but can be flat_out removed w/o breaking this test suite. As we tread forward, we'll eventually get around to removing all
@bigtest
deps and moving necessary interactors (if needed) to@folio/stripes-testing
.