Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STSMACOM-789 - Extend NotesAccordion and NotesSmartAccodion components to accept a prop hideNewButton #1414

Merged
merged 2 commits into from
Nov 20, 2023
Merged

STSMACOM-789 - Extend NotesAccordion and NotesSmartAccodion components to accept a prop hideNewButton #1414

merged 2 commits into from
Nov 20, 2023

Conversation

Terala-Priyanka
Copy link
Contributor

STSMACOM-789 - Extend NotesAccordion and NotesSmartAccodion components to accept a prop hideNewButton

@Terala-Priyanka Terala-Priyanka self-assigned this Nov 17, 2023
@Terala-Priyanka Terala-Priyanka marked this pull request as draft November 17, 2023 06:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 737271d. ± Comparison against base commit 34d516d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   12s ⏱️ ±0s
444 tests +1  408 ✔️ +1  36 💤 ±0  0 ❌ ±0 
446 runs  +1  410 ✔️ +1  36 💤 ±0  0 ❌ ±0 

Results for commit 737271d. ± Comparison against base commit 34d516d.

♻️ This comment has been updated with latest results.

@Terala-Priyanka Terala-Priyanka requested review from a team and gurleenkaurbp November 17, 2023 06:43
@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review November 17, 2023 06:43
zburke
zburke reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's just a simple conditional, but please add tests for this new prop. There is already decent test infrastructure for both components so hopefully it's straight forward.

@Terala-Priyanka
Copy link
Contributor Author

I know it's just a simple conditional, but please add tests for this new prop. There is already decent test infrastructure for both components so hopefully it's straight forward.

Hey @zburke
Added a unit test. Please re-review.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Terala-Priyanka Terala-Priyanka mentioned this pull request Nov 20, 2023
Merged
@Terala-Priyanka Terala-Priyanka merged commit a0da657 into master Nov 20, 2023
@zburke zburke deleted the STSMACOM-789 branch October 25, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@gurleenkaurbp gurleenkaurbp gurleenkaurbp approved these changes

@mariia-aloshyna mariia-aloshyna mariia-aloshyna approved these changes

Assignees

@Terala-Priyanka Terala-Priyanka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Terala-Priyanka @zburke @BogdanDenis @gurleenkaurbp @mariia-aloshyna