STSMACOM-872: Reset qindex once the search field is empty.
#1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
force-pushed
the
STSMACOM-872
branch
from
f62cf7f to
797f2aa
Compare
Dmytro-Melnyshyn
force-pushed
the
STSMACOM-872
branch
from
797f2aa to
dd431eb
Compare
|
BogdanDenis
approved these changes
Nov 5, 2024
| @@ -645,7 +645,7 @@ class SearchAndSort extends React.Component { | |||
| } = this.props; | |||
| this.log('action', 'cleared search query'); | |||
| this.setState({ locallyChangedSearchTerm: '' }); | |||
| this.transitionToParams({ query: '', ...extraParamsToReset }); | |||
| this.transitionToParams({ query: '', qindex: '', ...extraParamsToReset }); | |||
There was a problem hiding this comment.
Hey @Dmytro-Melnyshyn
Are you sure that this change is needed across all Folio apps that leverage SearchAndSort?
There was a problem hiding this comment.
Hey @Terala-Priyanka, this is a bug, it should be fixed everywhere.
mariia-aloshyna
approved these changes
Nov 7, 2024
zburke
pushed a commit
that referenced
this pull request
Nov 15, 2024
(cherry picked from commit 96af01a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid resetting the selected search option when the text in the search box becomes empty.
Issues
STSMACOM-872
Screencast
2024-11-04_16h28_15.mp4