Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STSMACOM-876 <EditableListForm> state.status initialize as null so it can pass null re-initialization checks on component update. #1540

Merged
merged 4 commits into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Add the `endDateInputRef` prop to `DateRangeFilter` to access the end date element. Refs STSMACOM-859.
* Remove unnecessary `aria-rowindex` in `ItemView` and `ItemEdit` components. Fixes STSMACOM-871.
* Check for `active` status of `<Settings>` navigation links independently from the applied href and query string. Query string should only be applied to active link. Refs STSMACOM-837.
* `<EditableListForm>` use `lodash.isEmpty` to check for empty `state.status` in re-initialization checks on component update. Fixes STSMACOM-876.

## [9.2.3] IN PROGRESS

Expand Down
2 changes: 1 addition & 1 deletion lib/EditableList/EditableListForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ class EditableListForm extends React.Component {

// needed for instances where initialValues arrive AFTER initialization.
static getDerivedStateFromProps(props, state) {
if (!state.status) {
if (isEmpty(state.status)) {
return {
status: buildStatusArray(props.initialValues.items)
};
Expand Down
Loading