Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STSMACOM-875 Use <IfAnyPermission> and stripes.hasAnyPerm to check for Notes assign/unassign perm #1549

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Dec 10, 2024

Description

It seems that permission's replaces property doesn't work as it was expected to, so we have to check for both old and new permission names. Use <IfAnyPermission> and stripes.hasAnyPerm to check for Notes assign/unassign perm.

Screenshots

image

Issues

STSMACOM-875

(cherry picked from commit fee9ec8)
(cherry picked from commit 221e07f)

BogdanDenis and others added 3 commits December 10, 2024 07:09
…k for Notes assign/unassign perm. (#1538)

## Description
It seems that permission's `replaces` property doesn't work as it was
expected to, so we have to check for both old and new permission names.
Use `<IfAnyPermission>` and `stripes.hasAnyPerm` to check for Notes
assign/unassign perm.

## Screenshots

![image](https://github.com/user-attachments/assets/079600d9-5e93-4ab2-8196-a0d78c08975c)

## Issues
[STSMACOM-875](https://folio-org.atlassian.net/browse/STSMACOM-875)

(cherry picked from commit fee9ec8)
## Description
Remove `.only` in tests so that all tests can run

(cherry picked from commit 221e07f)
Copy link

Bigtest Unit Test Results

  1 files  ±0    1 suites  ±0   14s ⏱️ ±0s
508 tests ±0  466 ✅  - 5  42 💤 +5  0 ❌ ±0 
510 runs  ±0  468 ✅  - 5  42 💤 +5  0 ❌ ±0 

Results for commit 5e35bc8. ± Comparison against base commit 524926c.

@zburke zburke merged commit b4a3849 into b9.2 Dec 10, 2024
25 checks passed
@zburke zburke deleted the STSMACOM-875-b9.2 branch December 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants