Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICHKOUT-948: Actions for check out item don't work #909

Closed
wants to merge 1 commit into from

Conversation

artem-blazhko
Copy link
Contributor

Purpose

By some reason mutator.query.update does not have any impact on current application url.
In the scope of this PR I use history.push instead of mutator.query.update.

Refs

UICHKOUT-948

Copy link

Jest Unit Test Results

  1 files  ±0   22 suites  ±0   22s ⏱️ -1s
413 tests ±0  413 ✅ ±0  0 💤 ±0  0 ❌ ±0 
414 runs  ±0  414 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e7433c1. ± Comparison against base commit 072aeeb.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
ViewItem component when all data provided should trigger "query.update" for item with correct arguments ‑ ViewItem component when all data provided should trigger "query.update" for item with correct arguments
ViewItem component when all data provided should trigger "query.update" for loan details with correct arguments ‑ ViewItem component when all data provided should trigger "query.update" for loan details with correct arguments
ViewItem component when all data provided should trigger "query.update" for loan policy with correct arguments ‑ ViewItem component when all data provided should trigger "query.update" for loan policy with correct arguments
ViewItem component when all data provided should trigger "history.push" for item with correct arguments ‑ ViewItem component when all data provided should trigger "history.push" for item with correct arguments
ViewItem component when all data provided should trigger "history.push" for loan details with correct arguments ‑ ViewItem component when all data provided should trigger "history.push" for loan details with correct arguments
ViewItem component when all data provided should trigger "history.push" for loan policy with correct arguments ‑ ViewItem component when all data provided should trigger "history.push" for loan policy with correct arguments

@artem-blazhko artem-blazhko requested review from Dmitriy-Litvinenko and a team March 11, 2025 09:53
@artem-blazhko
Copy link
Contributor Author

Problem is not reproducible

@artem-blazhko artem-blazhko deleted the UICHKOUT-948 branch March 11, 2025 10:35
@zburke
Copy link
Member

zburke commented Mar 11, 2025

@artem-blazhko, It's possible (ahem, **99% likely) that the root cause of this problem, based on the timing of when the ticket was filed and the nature of the bug, was folio-org/stripes-core#1584.

Among other things, PR 1584 refactored from a class-component to a functional one caused a bunch of trouble that we tried to address by putting more things on the dependency array in folio-org/stripes-core#1600. We finally gave up and restored some of the original class-based component in folio-org/stripes-core#1604. Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants