Rebase of task-force from Orchid release branch. #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt (#1453) * add composit job details to Job component * add tests, update babel config/dependencies * add column header translations, job parts column * add additional tests for jobLogsContainer - job parts column * test jobLogsContainer with split job entry * make DataFetcher paths functional depending on upload configuration * add further optional chaining to data fetcher export * add tests for functional URL function (getJobSplittingURL) in DataFetcher
* translations, layout for cancellation modal * add endpoint call, test for canceling a multipart job * remove comment * clean up Job imports, improve test coverage.
* render download link in job summary page * update tests for Job summary, add tests * improve layout/behavior of SourceDownloadLink component * mock callout from stripes-core * appease the lint gods
…ion (#1458) * display jobParts column in Jobs using this profile section * cleaner wrap for settings, tests for ViewJobProfile * provide upload definition id in test context
…g/ui-data-import into task-force-merge-orchid
JohnC-80
requested review from
mariia-aloshyna,
OleksandrHladchenko1 and
jakhongirabdukhamdiov
|
Kudos, SonarCloud Quality Gate passed! |
mariia-aloshyna
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draft for now as we continue to troubleshoot any issues.
The overarching change is conditional behavior based on whether or not object storage capabilities are enabled (S3). This is determined by a response from the
data-import/splitStatusendpoint.If this returns
false, behavior is kept the same.If the response is
true, then a number of things change:MultipartUploaderclass which manages the above.Job partsinformation (ex: 3 of 7) in the JobLogs table.compositeDetailsin its own utility files.