Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDATIMP-1504: Match profile: update options for MARC Bibliographic 'Incoming records' #1469

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* Change validation messages which were represented in code format (UIDATIMP-1473)
* *BREAKING* bump `react` to `v18`, and dev-deps accordingly (UIDATIMP-1485)
* Match profile: update options for Instance "Incoming records" (UIDATIMP-1501)
* Match profile: update options for MARC Bibliographic "Incoming records" (UIDATIMP-1504)
* Update Node.js to v18 in GitHub Actions (UIDATIMP-1507)
* leverage jest-config-stripes for all jest and testing-library packages (UIDATIMP-1508)
* *BREAKING* bump `react-intl` to `v6.4.4` (UIDATIMP-1520)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,10 @@ describe('IncomingRecordMenu component', () => {
});

describe('when exisiting record type is "MARC_BIBLIOGRAPHIC"', () => {
it('should render "MARC Bibliographic", "MARC Authority" and "Static value" options', () => {
it('should render "MARC Bibliographic" and "Static value" options', () => {
const { getByText } = renderIncomingRecordMenu({ open: true, existingRecordType: 'MARC_BIBLIOGRAPHIC' });

expect(getByText('MARC Bibliographic')).toBeVisible();
expect(getByText('MARC Authority')).toBeVisible();
expect(getByText('Static value (submatch only)')).toBeVisible();
});
});
Expand Down
1 change: 1 addition & 0 deletions src/utils/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,7 @@ export const ALLOWED_INCOMING_RECORD_TYPES = {
]),
[FOLIO_RECORD_TYPES.MARC_BIBLIOGRAPHIC.type]: omit(MATCH_INCOMING_RECORD_TYPES, [
MATCH_INCOMING_RECORD_TYPES.MARC_HOLDINGS.type,
MATCH_INCOMING_RECORD_TYPES.MARC_AUTHORITY.type,
]),
[FOLIO_RECORD_TYPES.MARC_AUTHORITY.type]: omit(MATCH_INCOMING_RECORD_TYPES, [
MATCH_INCOMING_RECORD_TYPES.MARC_HOLDINGS.type,
Expand Down