Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDATIMP-1503: Match profile: update options for "Incoming records" #1470

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

mariia-aloshyna
Copy link
Contributor

@mariia-aloshyna mariia-aloshyna commented Sep 22, 2023

Purpose

  • To update options for Match profile existing record types:
    Instance -> Marc bib, Static value
    Holdings -> Marc bib, Static value
    Item -> Marc bib, Static value
    Marc bib -> Marc bib, Static value
    Marc authority -> Marc authority, Static value

Approach

  • Created map to render incoming record types for selected existing record type
  • Reset incoming record type value to default when switching between existing record types
  • Update unit tests

Refs

https://issues.folio.org/browse/UIDATIMP-1503
https://issues.folio.org/browse/UIDATIMP-1505

Screenshots

Screen.Recording.2023-09-22.at.13.16.58.mov

UIDATIMP-1505: Match profile: update options for MARC Authority "Incoming records"
@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Jest Unit Test Statistics

       1 files  ±0     216 suites  ±0   11m 43s ⏱️ - 2m 51s
1 142 tests ±0  1 139 ✔️ ±0  3 💤 ±0  0 ±0 
1 153 runs  ±0  1 150 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit 7ad6d03. ± Comparison against base commit 80d8194.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 7ad6d03. ± Comparison against base commit 80d8194.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, fix tests in IncomingRecordMenu component (warnings and unused existingRecordType prop)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

70.5% 70.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mariia-aloshyna mariia-aloshyna merged commit f461b6c into master Sep 25, 2023
@mariia-aloshyna mariia-aloshyna deleted the UIDATIMP-1503 branch September 25, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants